Skip to content

[feat:filebeat/input/redis/slowlog] Add Redis replication role to slowlogs#40578

Merged
rdner merged 8 commits intoelastic:mainfrom
jdheyburn:jdheyburn/filebeat/input/redis/add-role
Sep 18, 2024
Merged

[feat:filebeat/input/redis/slowlog] Add Redis replication role to slowlogs#40578
rdner merged 8 commits intoelastic:mainfrom
jdheyburn:jdheyburn/filebeat/input/redis/add-role

Conversation

@jdheyburn
Copy link
Contributor

@jdheyburn jdheyburn commented Aug 21, 2024 •
edited
Loading

  • Enhancement

Proposed commit message

See title

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

No disruption expected

Author's Checklist

  • N/A

How to test this PR locally

Related issues

Use cases

Filtering on slow logs created by the master, ignoring replicas.

Screenshots

Logs

@jdheyburn jdheyburn requested a review from a team as a code owner August 21, 2024 16:28
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 21, 2024
@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @jdheyburn? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Aug 21, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 21, 2024

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 21, 2024
@pierrehilbert pierrehilbert requested review from faec and removed request for flexitrev August 21, 2024 16:31
mauri870
mauri870 reviewed Aug 22, 2024
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b jdheyburn/filebeat/input/redis/add-role upstream/jdheyburn/filebeat/input/redis/add-role
git merge upstream/main
git push upstream jdheyburn/filebeat/input/redis/add-role

@ycombinator
Copy link
Contributor

ycombinator commented Sep 11, 2024

@jdheyburn In addition to @mauri870's feedback, there are also some merge conflicts now on this PR. Would you mind addressing the feedback and resolving those conflicts by rebasing this PR on main? Thanks!

@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
@jdheyburn
Copy link
Contributor Author

jdheyburn commented Sep 11, 2024

Sorry for the delay @mauri870 @ycombinator - hope the latest merge fixes those issues now 🙏🏻

@jdheyburn jdheyburn requested a review from mauri870 September 11, 2024 17:17
mauri870
mauri870 reviewed Sep 12, 2024
View reviewed changes
@jdheyburn jdheyburn requested a review from mauri870 September 12, 2024 15:43
@mauri870 mauri870 added backport-skip Skip notification from the automated backport with mergify Filebeat Filebeat and removed backport-8.x Automated backport to the 8.x branch with mergify labels Sep 13, 2024
@mauri870
Copy link
Member

mauri870 commented Sep 13, 2024

buildkite test this

@pierrehilbert pierrehilbert requested a review from rdner September 16, 2024 07:49
@jdheyburn
Copy link
Contributor Author

jdheyburn commented Sep 18, 2024

It would be great to get this PR merged in ahead of the next filebeat release - thank you!

@mauri870 @rdner

@mauri870
Copy link
Member

mauri870 commented Sep 18, 2024

/test

@pierrehilbert
Copy link
Contributor

pierrehilbert commented Sep 18, 2024

run docs-build

@pierrehilbert pierrehilbert added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 18, 2024
@rdner rdner merged commit bfed178 into elastic:main Sep 18, 2024
mergify bot pushed a commit that referenced this pull request Sep 18, 2024
@jdheyburn @mauri870 @mergify
[feat:filebeat/input/redis/slowlog] Add Redis replication role to slo…
9a0fcff 
…wlogs (#40578)

Add Redis replication role to slowlogs

---------

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
(cherry picked from commit bfed178)
@mergify mergify bot mentioned this pull request Sep 18, 2024
Merged
7 tasks
pierrehilbert pushed a commit that referenced this pull request Sep 19, 2024
@mergify @jdheyburn
[feat:filebeat/input/redis/slowlog] Add Redis replication role to slo…
d2d2840 
…wlogs (#40578) (#40892)

Add Redis replication role to slowlogs

---------

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
(cherry picked from commit bfed178)

Co-authored-by: Joseph Heyburn <34041368+jdheyburn@users.noreply.github.com>
@jdheyburn
Copy link
Contributor Author

jdheyburn commented Oct 22, 2024

Hey team, this has been merged for a month but I've not seen it be released on the latest version: https://github.com/elastic/beats/releases/tag/v8.15.3

When can we expect it deployed out?

@ishleenk17
Copy link
Member

ishleenk17 commented Oct 24, 2024

Hey team, this has been merged for a month but I've not seen it be released on the latest version: https://github.com/elastic/beats/releases/tag/v8.15.3

When can we expect it deployed out?

This has been backported to 8.x
Hence, it will be available in 8.16. It would not be available in 8.15.x releases.

@jdheyburn
Copy link
Contributor Author

jdheyburn commented Oct 24, 2024

@ishleenk17 Thanks for the update, when is 8.16 due to be released?

@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdner rdner rdner approved these changes

@mauri870 mauri870 mauri870 approved these changes

@faec faec Awaiting requested review from faec

Assignees

@jdheyburn jdheyburn

Labels

backport-8.x Automated backport to the 8.x branch with mergify backport-skip Skip notification from the automated backport with mergify Filebeat Filebeat Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[filebeat/input/redis/slowlog] Add field for the Redis replication role

7 participants

@jdheyburn @elasticmachine @ycombinator @mauri870 @pierrehilbert @ishleenk17 @rdner

Comments